[xmlsec] Big patch to xmlsec in recent OpenOffice.org sources

Aleksey Sanin aleksey at aleksey.com
Sun Feb 27 19:46:27 PST 2005


>>>> 1) xmlsec/include/xmlsec/mscrypto/akmngr.c, 
>>>> xmlsec/src/mscrypto/akmngr.c
>>>> Why do you need "AppliedKeyManager"? How is it different from the
>>>> "DefaultKeyManager" and do you think it would be easier to just
>>>> merge the two?
>>>>
>>> The AppliedKeyManager enable user specify their preferred key store 
>>> and certificate store. It would be a good idea just simply support 
>>> both of the two manager.
>>>
>> I would really love to merge these two guys together. May be we can just
>> add functions to set prefered key/certs store to the DefaultKeysManager
>> and provide reasonable defaults as we do now. I believe this way we can
>> avoid un-necessary code duplication (see item 0) too).
>>
> It's a little harder, but definitely better. :-)
It's not that hard and I already mostly done with it. The only
question I have is why do you have the following code at the end
of xmlSecMSCryptoX509StoreAdoptXXXX functions? Is this just for
debugging or there is other reason for it?

	{
		PCCERT_CONTEXT ptCert ;

		ptCert = NULL ;
		while( 1 ) {
			ptCert = CertEnumCertificatesInStore( ctx->trusted, ptCert ) ;
			if( ptCert == NULL )
				break ;
		}
	}

Thanks,
Aleksey



More information about the xmlsec mailing list