[webmasters] Re: [xmlsec] Big patch to xmlsec in recent OpenOffice.org sources

[Andrew Fan]

Hi Aleksey,

I have to say sorry to you and all of others about the mail thread. The 
e-mailed are filtered into aother folder in my email, and I have not 
read it for a very long time. So sorry.

But I never forgot to contribute the patches back into the main track 
from the very beginning. And now, it seems that I have got the 
permission from my bosses. :-)  Michael Mi and Chandler Peng will work 
on the integration, I will help them during the integrating process.

About the patch, why is it so big? what had happened at the patch? I try 
to illustrate it in some very simple words.
1. I only made some changes over nss and ms crypto enginers;
2. For ms crypto enginer, I did some changes over keystore mainly, the 
patch is quite smalll;
3. For nss enginer, the patch shows a big difference about how to find 
keys and personal certificates from key store and certificate store.

Detailed infomation, I'll try to explain during the integration.

Thanks & Regards,
Andrew Fan

Chandler, would you please create a new diff according with "diff -uN". 
Thanks.

Aleksey Sanin wrote:

> Andrew,
>
> I would appreciate if you can generate a new "diff -uN" patch against
> the current xmlsec CVS trunk because it is pretty hard to read the
> patch at
>
> http://external.openoffice.org/source/browse/external/libxmlsec/xmlsec1-1.2.4.patch 
>
>
> Plus I have some problems applying the current patch (mainly with new
> files you've added).
>
> Also it is a pretty big patch and I would really appreciate if you
> can write up some comments about it (something like "the change on
> lines AAA-BBB, file CCC, lines DDD-EEE, file FFF, ... fixes bug
> ZZZ" will do).
>
> Thanks,
> Aleksey
>
> Malte Timmermann wrote:
>
>> Andrew,
>>
>> can you please work with Aleksey to get all your changes into xmlsec?
>>
>> Would be great if we could get rid of our patch :)
>>
>> Malte.
>>