<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=utf-8">
<meta name="x_Generator" content="Microsoft Word 15 (filtered medium)">
<style>
<!--
@font-face
{font-family:"Cambria Math"}
@font-face
{font-family:Calibri}
p.x_MsoNormal, li.x_MsoNormal, div.x_MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif}
a:x_link, span.x_MsoHyperlink
{color:blue;
text-decoration:underline}
a:x_visited, span.x_MsoHyperlinkFollowed
{color:#954F72;
text-decoration:underline}
.x_MsoChpDefault
{}
@page WordSection1
{margin:1.0in 1.0in 1.0in 1.0in}
div.x_WordSection1
{}
-->
</style>
<div lang="EN-US" link="blue" vlink="#954F72">
<div class="x_WordSection1">
<p class="x_MsoNormal">I’ll send a PR shortly, no problem</p>
<p class="x_MsoNormal"> </p>
<p class="x_MsoNormal">Sent from <a href="https://go.microsoft.com/fwlink/?LinkId=550986">
Mail</a> for Windows 10</p>
<p class="x_MsoNormal"> </p>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Aleksey Sanin <aleksey@aleksey.com><br>
<b>Sent:</b> Friday, June 8, 2018 6:44:29 PM<br>
<b>To:</b> Peter Budai; xmlsec@aleksey.com<br>
<b>Subject:</b> Re: [xmlsec] Include file order</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:11pt;">
<div class="PlainText">Interesting. Looks like libxslt is now including some windows crypto<br>
code that triggered this issue.<br>
<br>
I think changing includes order should be fine. Nothing in xmlsec<br>
should depend on includes order. Do you mind sending a PR?<br>
<br>
Aleksey<br>
<br>
On 6/8/18 2:44 AM, Peter Budai wrote:<br>
> <br>
> <br>
> With the latest release I have noticed that the build under MSYS2/MINGW<br>
> is failing with the following message:<br>
> <br>
> ../../../src/openssl/x509.c:109:66: error: expected declaration<br>
> specifiers or '...' before '(' token<br>
> <br>
> static xmlChar* xmlSecOpenSSLX509NameWrite (X509_NAME* nm);<br>
> <br>
> ^<br>
> <br>
> ../../../src/openssl/x509.c: In function<br>
> 'xmlSecOpenSSLX509SubjectNameNodeWrite':<br>
> <br>
> <br>
> <br>
> More detailed build log you can see here:<br>
> <a href="https://ci.appveyor.com/project/peterbud/xmlsec/build/job/sc82e41xseg7c391#L494">
https://ci.appveyor.com/project/peterbud/xmlsec/build/job/sc82e41xseg7c391#L494</a><br>
> <br>
> <br>
> <br>
> The problem in my understanding is that Windows headers also #define<br>
> some names that openssl uses too. Openssl headers #undef the offending<br>
> names before reusing them. But if those offending Windows headers get<br>
> included _/after/_ the openssl headers the namespace gets polluted.<br>
> <br>
> <br>
> <br>
> As a solution I have changed the include order in the openssl/x509.c and<br>
> openssl/x50vfy.c files, aka moved the openssl includes as the last files<br>
> to include, and that solved the problem, I was able to compile and<br>
> execute all the tests.<br>
> <br>
> <br>
> <br>
> However I’m not sue this is the right solution. Any opinion?<br>
> <br>
> <br>
> <br>
> Peter<br>
> <br>
> <br>
> <br>
> _______________________________________________<br>
> xmlsec mailing list<br>
> xmlsec@aleksey.com<br>
> <a href="http://www.aleksey.com/mailman/listinfo/xmlsec">http://www.aleksey.com/mailman/listinfo/xmlsec</a><br>
> <br>
</div>
</span></font>
</body>
</html>